-
Notifications
You must be signed in to change notification settings - Fork 46
feat: add animated wallpaper support (GIF/video) with hardware-accelerated decoding #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ericky14
wants to merge
17
commits into
pop-os:master
Choose a base branch
from
Ericky14:feat/live-wallpapers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
47a12b4
feat: add hardware-accelerated video wallpaper support
195f74d
chore: reduce verbosity of video logs
29a934e
perf(gif): use viewport GPU scaling for GIF rendering
9f47068
fix: detect and demote broken NVIDIA decoders for H.264 playback
0b440e8
chore: remove uneeded file
4935e14
chore: add readme section about h264 support on amd
8c064c3
chore: fix lint warning with no default feature flag
e90e49c
fix: system freezing sometimes when exiting cosmic-bg process
e6ce107
chore: update readme to reflect latest changes
08b28a6
chore: add todo comment
3a77380
feat: add both static and animated AVIF support
335d200
fix: properly cleanup dmabuf buffers to prevent fd leak
969783b
chore: fix lint/format
9a7b05a
fix: correctly detect vaapipostproc for AMD and add extra details to …
a530786
feat: remove gif support
857d532
fix: add missing debian control packages and fix videos not working o…
bef7a50
feat: bring back try_vaapi_wlshm_pipeline and force try_vaapi_dmabuf_…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the libav and ugly packages contain codecs which are illegal for us to distribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can switch to openh264 and do some testing to see if it works well still.
But waiting on @jackpot51 before I spend any more of my time on this, he didn't sound like he wants this addition in cosmic-bg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the animated image support should be packaged as its own separate crate that is shareable across apps that need the same functionality. And image/video detection would be better done based on media content instead of the extension. If something can be upstreamed to the gstreamer maintainers, it should. Likewise if possible it would be a good idea to contribute iced-specific integrations to iced-player.