cosmetic improvements #1276
cosmetic improvements #1276
Conversation
| @@ -1,4 +1,4 @@ | |||
| import { createConfig } from "@ponder/core"; | |||
| import { createConfig } from "ponder"; | |||
| @@ -1,27 +1,15 @@ | |||
| /// <reference types="ponder/virtual" /> | |||
|
|
|||
| declare module "ponder:register" { | |||
There was a problem hiding this comment.
What's the full list of names you considered here? Want to get this right, because it's going to show up in a LOT of code snippets for a long time :)
Edit: Oh, I figured this was the name that would replace "@/generated" but now I see that's different. Do you think we should rename "@/generated" in this release? I lean yes.
There was a problem hiding this comment.
Yes I think we should replace @/generated, but I haven't done it yet.
This ponder:register is an entirely internal thing that is used to pass type information back into the packages/core/src/types.d.ts.
| import { initTRPC } from "@trpc/server"; | ||
| import { eq } from "ponder"; |
There was a problem hiding this comment.
Is there any value to using different entrypoints here?
import { eq } from "ponder/db";
// or
import { eq } from "ponder/drizzle";
// or
import { eq } from "ponder/sql";Everything from top-level seems fine/simple, just curious if you gave it any thought.
There was a problem hiding this comment.
Let's take another look on monday
| @@ -121,8 +121,7 @@ export function createTelemetry({ | |||
|
|
|||
| // Attempt to find and read the users package.json file. | |||
| const packageJson = getPackageJson(options.rootDir); | |||
| const ponderCoreVersion = | |||
| packageJson?.dependencies?.["@ponder/core"] ?? "unknown"; | |||
| const ponderCoreVersion = packageJson?.dependencies?.ponder ?? "unknown"; | |||
@ponder/core->ponderponder:schemaponder-env.d.tsRemaining
@/generated