-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts + native transfers #1210
Open
kyscott18
wants to merge
55
commits into
v0.8
Choose a base branch
from
accounts
base: v0.8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
2daf668
start new filter impl
kyscott18 35d5d00
debug rpc types
kyscott18 3cfd157
withLog
kyscott18 f987047
add debug helper functions
kyscott18 cc5a3f6
syncTrace in sync-historical added with filter matching
khaidarkairbek 1a61820
syncTrace filtering modified, blockwise processing added
khaidarkairbek d15808d
sync-realtime: added tx/transfer factories
khaidarkairbek 600304d
sync: fragments and encoding for transaction/transfer filters
khaidarkairbek b318ead
sync-realtime: transaction/trasfer filter added
khaidarkairbek 0ab76da
sync-realtime: handleBlock is modified for new filters
khaidarkairbek 57bfc82
sync-realtime: fetchBlockEventData changed to debug and new filters f…
khaidarkairbek 3f3f82d
update historical sync
kyscott18 06b9060
build checkpoint for traces
kyscott18 3d944f0
record failed traces
kyscott18 479be95
implement insert traces db method
kyscott18 6681242
.
kyscott18 41412e6
cleanup realtime
kyscott18 edbbea0
corrections: minor changes
khaidarkairbek 51e87df
sync-historical: traceCache added
khaidarkairbek a7052f3
sync-realtime: trace traversal added in fetchBlockEventData and handl…
kyscott18 e7dcfbb
sync: buildEvents and decodeEvents modfied
khaidarkairbek 5640a6a
fix debug type
kyscott18 537f795
Merge branch 'v0.8' into accounts
kyscott18 5293137
new filter types
kyscott18 abaeae8
Merge branch 'accounts' of https://github.com/0xOlias/ponder into acc…
kyscott18 735d587
decodeEvents + buildEvents
kyscott18 e266901
Merge branch 'v0.8' into accounts
kyscott18 269c1d4
sync-historical: transaction filter
khaidarkairbek fa48e6a
getEvents
kyscott18 5e23f17
Merge branch 'accounts' of https://github.com/0xOlias/ponder into acc…
kyscott18 a9c9d69
account sources
kyscott18 ad82daa
accounts config
kyscott18 c600555
sync-realtime: fetchBlockEventData and handleBlock modified to handle…
khaidarkairbek 9a60456
cleanup realtime logs
kyscott18 f5ba161
minor fix
khaidarkairbek b4ca245
build accounts
kyscott18 6f29077
start historical sync tests
kyscott18 a85ae63
update sync tests
kyscott18 b12eacc
sync: handle factory address
khaidarkairbek f0fb96f
cleanup
kyscott18 c9f4ed9
Merge branch 'accounts' of https://github.com/0xOlias/ponder into acc…
kyscott18 c9a40aa
fix transport tests
kyscott18 3b4cd1f
realtime sync tests
kyscott18 04c934e
fix typecheck
kyscott18 0ca8af0
account specific test
kyscott18 0c97911
accounts example
kyscott18 7c2cfa4
fix virtual types
kyscott18 587e3de
cleanup sync
kyscott18 ecb3482
note
kyscott18 c9f5e1a
transaction includeReverted
kyscott18 aae6b18
cleanup
kyscott18 5bef6b0
fix: config
kyscott18 ec42276
sync: factory filter
khaidarkairbek 017466c
sync: factory filter cont.
khaidarkairbek 597a65f
set
kyscott18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not super clear, this function returns true for the case "should this trace be saved in the database" and not "does this trace exactly match the filter such that it will cause an indexing function to run". The reason for the distinction is that we don't want the cache to be completely useless when the filter type slightly changes. For that reason this check should be removed.
In this example, if the user decides that they want to include reverted traces after they have already fully synced their app, every block will need to be resynced.
Maybe we could add some comments acknowledging the properties that are ignored.