Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sale details + region info #11188

Merged
merged 11 commits into from
Jan 20, 2025
Merged

Conversation

piggydoughnut
Copy link
Contributor

@piggydoughnut piggydoughnut commented Jan 9, 2025

Added:

  • detaled phase data for historical sale
  • information about the region that is being currently sold - dates and relay chain blocks
  • links to other coretime resellers
  • link to DotLake Dashboard
  • link to a price graph on subscan

This tab is useful for people who need numbers connected to sales, when each phase started/finished, which dates, blocks, etc.

Resolves #11182

Screenshot 2025-01-17 at 8 35 11 PM

…nt region dates on the sale overview, links to other coretime resellers
@piggydoughnut piggydoughnut marked this pull request as draft January 9, 2025 06:14
@piggydoughnut piggydoughnut marked this pull request as ready for review January 17, 2025 07:32
@piggydoughnut piggydoughnut changed the title WIP: More sale details + region info More sale details + region info Jan 17, 2025
name: 'Interlude/Renewals phase'
},
[PhaseName.PriceDiscovery]: {
description: 'The period during which cores are available for both purchase and renewal. The price is linearly declining price.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO The price is linearly declining price. sounds a bit off - maybe something like: The price decreases linearly over time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏽‍♀️ totally. The price is a price you know 😅 😆

name: 'Price Discovery phase'
},
[PhaseName.FixedPrice]: {
description: 'The period during which cores are available for both purchase and renewal. The price is fixed price towards the end of the sales period.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'The period during which cores are available for both purchase and renewal. The price is fixed price towards the end of the sales period.',
description: 'The period during which cores are available for both purchase and renewal. The price is a fixed price towards the end of the sales period.',

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks amazing to me. Just a few nits

@piggydoughnut piggydoughnut merged commit fd45bb8 into master Jan 20, 2025
5 checks passed
@piggydoughnut piggydoughnut deleted the dm-11182-show-region-for-sale branch January 20, 2025 02:28
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coretime Sale Tab - Show what Region is for sale
3 participants