Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridges patch applied for stable2409 #519

Merged
merged 20 commits into from
Jan 16, 2025

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Dec 23, 2024

Relates to: paritytech/polkadot-sdk#6781
Relates to: paritytech/polkadot-sdk#6536
Closes: paritytech/parity-bridges-common#3017

Basically, this PR reverts back the congestion mechanism for Bridges, which was removed by #490 and later reverted by paritytech/polkadot-sdk#6781.

  • Does not require a CHANGELOG entry

TODO/Follow-ups

  • run bridges zombienet tests
  • fresh weights for relevant pallets

@bkontur
Copy link
Contributor Author

bkontur commented Dec 23, 2024

/cmd fmt

Copy link

Command "fmt" has started 🚀 See logs here

Copy link

Command "fmt" has finished ✅ See logs here

@bkontur
Copy link
Contributor Author

bkontur commented Dec 27, 2024

/cmd fmt

Copy link

Command "fmt" has started 🚀 See logs here

Copy link

Command "fmt" has finished ✅ See logs here

@acatangiu acatangiu mentioned this pull request Jan 7, 2025
6 tasks
@@ -133,7 +133,7 @@ ON_BRIDGE_HUB_KUSAMA_SOVEREIGN_ACCOUNT_FOR_LANE_00000001_bhpd_ThisChain="EoQBtnw
ON_BRIDGE_HUB_KUSAMA_SOVEREIGN_ACCOUNT_FOR_LANE_00000001_bhpd_BridgedChain="EoQBtnwp4jMtCEpV7CPsssT6bdDHuHZmf3aGXxHJiSA4Dz3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will these tests be integrated into CI? :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I think the main issue is the sudo tweaking mentioned in paritytech/parity-bridges-common#3016, but it should be solvable. Additionally, there are open issues for adding Chopsticks support.

I created a tracking issue for this: #544.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sudo can just be worked around by doing on chain proposal and fast track it with a fake fellowship :D For sure a little bit more complicated, but doable with chopsticks.

@bkontur
Copy link
Contributor Author

bkontur commented Jan 16, 2025

/merge

@fellowship-merge-bot fellowship-merge-bot bot merged commit 20ac6ff into polkadot-fellows:main Jan 16, 2025
52 checks passed
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests and setup multiple relayers for "free header" feature for polkadot-fellows
6 participants