Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(supabase-postgres): image with -c fsync=off CMD for CI #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lediur
Copy link
Contributor

@lediur lediur commented Jul 27, 2022

Add a copy of the supabase-postgres Dockerfile with -c fsync=off added to the CMD.

@lediur lediur requested a review from bchrobot July 27, 2022 18:53
@lediur lediur changed the title feat(supabase-postgres): image with '-c fsync=off' CMD for CI feat(supabase-postgres): image with -c fsync=off CMD for CI Jul 27, 2022
Copy link
Member

@bchrobot bchrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small documentation change but otherwise looks good!

Comment on lines +7 to +8
You need to log into Google Artifact Registry (GAR) before executing these commands. Follow the steps [here](https://cloud.google.com/artifact-registry/docs/docker/authentication#token).
If using the Access Token method, use the existing `[email protected]` service account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the gcloud credential helper should be linked to by default and mentioned as the preferred method for building locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants