Adds tooltip and spans to icons for better accessiblity. #6156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
imsidkg
commented
Jul 13, 2025
imsidkg
commented
- Closes icon buttons should have proper accessibility #5591
|
@imsidkg is attempting to deploy a commit to the polar-sh Team on Vercel. A member of the Team first needs to authorize it. |
|
@psincraian Please review the changes and let me know if any further changes are required. |
psincraian
reviewed
Jul 22, 2025
There was a problem hiding this comment.
I will wait for @emilwidlund opinion on this PR as I have 1 doubt
| <NotificationsPopover /> | ||
| <SidebarTrigger /> | ||
| <NotificationsPopover isCollapsed={isCollapsed} /> | ||
| <TooltipProvider> |
There was a problem hiding this comment.
I think we should have only one tooltip provider in the layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.