Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/checkout: set customer_email and customer_name as plain str in output schema #4891

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

frankie567
Copy link
Member

The risk of keeping the validated type is that, for any reason, our validation constraints change, we break outputting past data that have been properly validated before that.

The good practice is then to avoid any validation when outputting data and trust what we have in DB.

Fix #4890

…in output schema

The risk of keeping the validated type is that, for any reason, our validation constraints change, we break outputting past data that have been properly validated before that.

The good practice is then to avoid any validation when outputting data and trust what we have in DB.

Fix #4890
@frankie567 frankie567 enabled auto-merge (rebase) January 24, 2025 12:17
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 0:18am
polar-sandbox 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 0:18am

Copy link
Contributor

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@frankie567 frankie567 merged commit fb2ae95 into main Jan 24, 2025
9 of 11 checks passed
@frankie567 frankie567 deleted the fix/4890 branch January 24, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant