server/checkout: remove payment_processor from CheckoutCreate

Fix #4748
polarsource · Jan 2, 2025 · a6be7ba · a6be7ba
1 parent 01f097f
commit a6be7ba
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 37 deletions.
diff --git a/server/polar/checkout/schemas.py b/server/polar/checkout/schemas.py
@@ -126,9 +126,6 @@ class CheckoutCreateBase(CustomFieldDataInputMixin, MetadataInputMixin, Schema):
     to the resulting order and/or subscription.
     """
 
-    payment_processor: Literal[PaymentProcessor.stripe] = Field(
-        description="Payment processor to use. Currently only Stripe is supported."
-    )
     discount_id: UUID4 | None = Field(
         default=None, description="ID of the discount to apply to the checkout."
     )

diff --git a/server/tests/checkout/test_endpoints.py b/server/tests/checkout/test_endpoints.py
@@ -11,7 +11,6 @@
 from polar.auth.scope import Scope
 from polar.checkout.schemas import CheckoutProductCreate
 from polar.checkout.service import checkout as checkout_service
-from polar.enums import PaymentProcessor
 from polar.integrations.stripe.service import StripeService
 from polar.kit.tax import calculate_tax
 from polar.kit.utils import utc_now
@@ -103,7 +102,6 @@ async def test_blocked_organization(
         checkout = await checkout_service.create(
             session,
             CheckoutProductCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_id=product.id,
             ),
             auth_subject,

diff --git a/server/tests/checkout/test_service.py b/server/tests/checkout/test_service.py
@@ -238,7 +238,6 @@ async def test_not_existing_price(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=uuid.uuid4(),
                 ),
                 auth_subject,
@@ -258,7 +257,6 @@ async def test_not_writable_price(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=product_one_time.prices[0].id,
                 ),
                 auth_subject,
@@ -285,9 +283,7 @@ async def test_archived_price(
         with pytest.raises(PolarRequestValidationError):
             await checkout_service.create(
                 session,
-                CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe, product_price_id=price.id
-                ),
+                CheckoutPriceCreate(product_price_id=price.id),
                 auth_subject,
             )
 
@@ -309,7 +305,6 @@ async def test_archived_product(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=product_one_time.prices[0].id,
                 ),
                 auth_subject,
@@ -339,7 +334,6 @@ async def test_amount_invalid_limits(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=product_one_time_custom_price.prices[0].id,
                     amount=amount,
                 ),
@@ -399,7 +393,6 @@ async def test_invalid_not_existing_subscription(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=price.id,
                     subscription_id=uuid.uuid4(),
                     metadata={"key": "value"},
@@ -425,7 +418,6 @@ async def test_invalid_not_existing_discount(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=price.id,
                     discount_id=uuid.uuid4(),
                 ),
@@ -451,7 +443,6 @@ async def test_invalid_not_applicable_discount(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=price.id,
                     discount_id=discount_fixed_once.id,
                 ),
@@ -482,7 +473,6 @@ async def test_invalid_paid_subscription(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=price.id,
                     subscription_id=subscription.id,
                     metadata={"key": "value"},
@@ -508,7 +498,6 @@ async def test_valid_fixed_price(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 amount=amount,
                 metadata={"key": "value"},
@@ -540,7 +529,6 @@ async def test_valid_free_price(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 amount=amount,
                 metadata={"key": "value"},
@@ -575,7 +563,6 @@ async def test_valid_custom_price(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 amount=amount,
                 metadata={"key": "value"},
@@ -608,7 +595,6 @@ async def test_valid_tax_id(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 customer_billing_address=Address.model_validate({"country": "FR"}),
                 customer_tax_id="FR61954506077",
@@ -632,7 +618,6 @@ async def test_valid_success_url_with_interpolation(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 success_url=HttpUrl(
                     "https://example.com/success?checkout_id={CHECKOUT_ID}"
@@ -659,7 +644,6 @@ async def test_valid_success_url_with_invalid_interpolation_variable(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 success_url=HttpUrl(
                     "https://example.com/success?checkout_id={CHECKOUT_SESSION_ID}"
@@ -691,7 +675,6 @@ async def test_silent_calculate_tax_error(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 customer_billing_address=Address.model_validate({"country": "US"}),
             ),
@@ -718,7 +701,6 @@ async def test_valid_calculate_tax(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 customer_billing_address=Address.model_validate({"country": "FR"}),
             ),
@@ -753,7 +735,6 @@ async def test_valid_subscription_upgrade(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 subscription_id=subscription.id,
                 metadata={"key": "value"},
@@ -787,7 +768,6 @@ async def test_invalid_custom_field_data(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=price.id,
                     custom_field_data=custom_field_data,
                 ),
@@ -810,7 +790,6 @@ async def test_valid_custom_field_data(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 custom_field_data={"text": "abc", "select": "a"},
             ),
@@ -837,7 +816,6 @@ async def test_valid_embed_origin(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 amount=amount,
                 embed_origin="https://example.com",
@@ -860,7 +838,6 @@ async def test_valid_tax_not_applicable(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 customer_billing_address=Address.model_validate({"country": "FR"}),
             ),
@@ -885,7 +862,6 @@ async def test_valid_discount(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 discount_id=discount_fixed_once.id,
             ),
@@ -908,7 +884,6 @@ async def test_product_not_existing(
             await checkout_service.create(
                 session,
                 CheckoutProductCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_id=uuid.uuid4(),
                 ),
                 auth_subject,
@@ -928,7 +903,6 @@ async def test_product_not_writable(
             await checkout_service.create(
                 session,
                 CheckoutProductCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_id=product_one_time.id,
                 ),
                 auth_subject,
@@ -951,7 +925,6 @@ async def test_product_archived(
             await checkout_service.create(
                 session,
                 CheckoutProductCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_id=product_one_time.id,
                 ),
                 auth_subject,
@@ -971,7 +944,6 @@ async def test_product_valid(
         checkout = await checkout_service.create(
             session,
             CheckoutProductCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_id=product_one_time.id,
             ),
             auth_subject,
@@ -998,7 +970,6 @@ async def test_invalid_customer(
             await checkout_service.create(
                 session,
                 CheckoutPriceCreate(
-                    payment_processor=PaymentProcessor.stripe,
                     product_price_id=price.id,
                     customer_id=uuid.uuid4(),
                 ),
@@ -1023,7 +994,6 @@ async def test_valid_customer(
         checkout = await checkout_service.create(
             session,
             CheckoutPriceCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_price_id=price.id,
                 customer_id=customer.id,
             ),
@@ -1050,7 +1020,6 @@ async def test_customer_metadata(
         checkout = await checkout_service.create(
             session,
             CheckoutProductCreate(
-                payment_processor=PaymentProcessor.stripe,
                 product_id=product_one_time.id,
                 customer_metadata={"key": "value"},
             ),