Skip to content

feat: Add nulls support for rolling_mean_by #25917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Voultapher wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add nulls support for rolling_mean_by #25917

Voultapher wants to merge 1 commit into from
+300 −38

Conversation

@Voultapher
Copy link
Collaborator

@Voultapher Voultapher commented Dec 31, 2025

Fixes: #25848

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 31, 2025
@Voultapher Voultapher force-pushed the implement-nulls-rolling-mean-by branch from d84a6a4 to 96d51c8 Compare December 31, 2025 15:24
@Voultapher
Copy link
Collaborator Author

Voultapher commented Dec 31, 2025

Run curl -LsSf https://astral.sh/uv/install.sh | sh
curl: (56) The requested URL returned error: 504
Error: Process completed with exit code 56.

CI failure seems unrelated, didn't find the run again button.

orlp
orlp requested changes Dec 31, 2025
View reviewed changes
crates/polars-time/src/chunkedarray/rolling_window/rolling_kernels/nulls.rs
)));
}
// start with a dummy index, will be overwritten on first iteration.
// SAFETY: FIXME
Copy link
Member

@orlp orlp Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixme? Safety here is trivial as 0..0 is in-bounds for any array.

Copy link
Member

@orlp orlp Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to rework Ag::new to just check to make it safe though, it's not called often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlp orlp orlp requested changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Null Support for rolling operations (e.g. rolling_xyz_by)

2 participants

@Voultapher @orlp