Skip to content

Conversation

@gab23r
Copy link
Contributor

@gab23r gab23r commented Dec 16, 2025

I copy pasted a bunch of code from list.gather. Should we mutualize things into some utility module ?

Part of: #21302

@gab23r gab23r changed the title feat: arr.gather feat: Add arr.gather Dec 16, 2025
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 87.84530% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.80%. Comparing base (37cda80) to head (ced99e7).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-ops/src/chunked_array/array/namespace.rs 86.75% 20 Missing ⚠️
crates/polars-plan/src/dsl/function_expr/array.rs 0.00% 1 Missing ⚠️
...polars-plan/src/plans/aexpr/function_expr/array.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25785      +/-   ##
==========================================
- Coverage   80.57%   79.80%   -0.78%     
==========================================
  Files        1764     1764              
  Lines      242704   242931     +227     
  Branches     3042     3044       +2     
==========================================
- Hits       195561   193864    -1697     
- Misses      46361    48285    +1924     
  Partials      782      782              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the changes-dsl Do not merge if this label is present and red label Dec 16, 2025
@orlp
Copy link
Member

orlp commented Dec 17, 2025

This should be a dedicated kernel rather than treating the array as a bunch of Series. Right now I don't see how this is any better than .arr.eval(pl.element().gather(idxs), as_list=True).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes-dsl Do not merge if this label is present and red enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants