perf: Fix cloud download speed regression #19734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
nameexhaustion
commented
Nov 12, 2024
nameexhaustion
commented
Nov 12, 2024
nameexhaustion
commented
Nov 12, 2024
| current_merged_range = range; | ||
| current_n_bytes = 0; | ||
| Some((v, current_idx)) | ||
| current_n_bytes = current_merged_range.len(); |
There was a problem hiding this comment.
fix incorrect re-initialization
…ola-rs#19730)" This reverts commit 62ef918.
nameexhaustion
force-pushed
the
ranges
branch
from
26f6c18
to
6204d20
Compare
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
nameexhaustion
commented
Nov 12, 2024
| let gap_tolerance = | ||
| (current_n_bytes.max(range.len()) / 8).clamp(1024 * 1024, 8 * 1024 * 1024); | ||
|
|
||
| leq_current_dist_to_chunk_size && distance <= gap_tolerance |
There was a problem hiding this comment.
The formatter broke with the existing if on the entire file 🥲, so I rewrote it to use descriptive variable names instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19730 - from benchmarking it performed worse.
In hindsight it's not worth adding that rule - even without it we will only have up to half of our requests being tiny in the worst case (in this worst case they would be interleaved).