Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add block height facets to sync behind log #891

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

crisog
Copy link
Contributor

@crisog crisog commented Jul 6, 2022

As of now, the block heights are only recorded in the error string. This is not very helpful to use in Datadog and we'll need it to make an strategy to balance out the sync allowance depending on how often nodes are out of sync.

@height
Copy link

height bot commented Jul 6, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@crisog crisog requested a review from adshmh July 6, 2022 13:52
@adshmh
Copy link
Contributor

adshmh commented Jul 15, 2022

Thanks for the PR. Does fisherman need updating with the same change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants