Xcode 16 beta 5: Fix snapshots test trait #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer possible to `@_spi(Experimental) import Testing`, so we can no longer ship a custom execution test trait. Instead of using such a trait to override a task local for the duration of a test, we can use a more general trait to store the information, and the assertion helpers can coalesce to the trait, instead.
mbrandonw
approved these changes
Aug 7, 2024
JustasL
added a commit
to vinted/swift-snapshot-testing
that referenced
this pull request
Dec 11, 2024
* main: (27 commits) Run swift-format Fix assertSnapshot for Swift Testing tests. (pointfreeco#916) Add an NB to @_implementationOnly import. Run swift-format Import only the implementation of Testing. (pointfreeco#903) fix missing inline snapshot testing (pointfreeco#887) Feature/fixed decimal separator (pointfreeco#889) Run swift-format Xcode 16 beta 5: Fix snapshots test trait (pointfreeco#885) Run swift-format Don't invoke XCTContext when running in the Testing framework. (pointfreeco#884) Run swift-format Fixed .failed record mode in inline snapshots. (pointfreeco#874) Point updated packages to swiftlang organization (pointfreeco#873) Fix recordIssue for Xcode beta 3. (pointfreeco#869) Run swift-format Beta support for Swift Testing, and other improvements. (pointfreeco#867) Run swift-format New `canGenerateNewSnapshots` to avoid automatically creating missing ones in CI (pointfreeco#768) Run swift-format ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer possible to
@_spi(Experimental) import Testing, so we can no longer ship a custom execution test trait.Instead of using such a trait to override a task local for the duration of a test, we can use a more general trait to store the information, and the assertion helpers can coalesce to the trait, instead.