Add option to disable counter suffixes #747
Open
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue here: #429
This allows users to disable the default behavior of snapshot creation, where a counter is added whenever a test doesn't specify a test name.
For tests that only validate one snapshot, adding a suffix to these tests seems excessive. For me, this would result in most test files looking like
MyViewControllerSnapshotTests/testLayout.1.pngand it would be nice to be able to disable this functionality when it's not desired to keep file names simpler:MyViewControllerSnapshotTests/testLayout.pngNote: This recreates #486 after the initial fork was deleted.