Override Test ID to ensure trait dependencies are cached #293
+51
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where reference typed dependencies weren't correctly cached if they were updated in-place rather than being fully overridden.
The root cause of this seems to be that
Test.current
isn't set duringprepare(for test: Test)
and as a result theCacheKey.testIdentifier
wasnil
during dependency setup.This PR creates an internalTestID
struct that can be explicitly overridden during dependency prep, but perhaps there's a more elegant solution that could be implemented inxctest-dymaic-overlay
directly.This PR is dependent on pointfreeco/swift-issue-reporting#137