Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added migration guide for 1.15 #3390

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Added migration guide for 1.15 #3390

merged 2 commits into from
Sep 17, 2024

Conversation

mbrandonw
Copy link
Member

This is a potential small issue that could come up with 1.15, and we've seen it brought up at least 2 or 3 times so far, so thought we could get a migration guide for it.

Comment on lines +39 to +41
swiftSettings: [
.enableUpcomingFeature("InferSendableFromCaptures"),
]),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly I found this wasn't effective in my codebase. We're on Xcode 15.4. Even with -enable-experimental-feature InferSendableFromCaptures -enable-upcoming-feature InferSendableFromCaptures in the SwiftCompile output in the build log, I still get that error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JimRoepcke, I'm not able to reproduce this, but if you can provide a minimal project that demonstrates the problem we will look into more. For now I am going to merge this as-is.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JimRoepcke
If you using local SwiftPackage, you should configure upcoming feature on Package.swift for SwiftPackage source code.
Configured OTHER_SWIFT_FLAGS in xcodeproj is not affect to SwiftPackage in my case.

@mbrandonw mbrandonw merged commit d631d48 into main Sep 17, 2024
6 of 12 checks passed
@mbrandonw mbrandonw deleted the update-migration-guide-1.15 branch September 17, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants