-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Factories: API #925
Conversation
Having some issues with the file controller interface, will continue to work on it.
|
Ok, think I've got the types figured out. TS was inferring some types incorrectly in handleFile, so I added manual typings. TS was also having issues with ramda's |
src/API/FileController.ts
Outdated
log(LogTypes.trace)('Adding files'), | ||
(xs) => xs.map(handleFile), | ||
(xs) => Promise.all(xs), | ||
(xs) => log(LogTypes.trace)('Added files')(xs), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some really weird reason, I have to give this a function like this... It doesn't make any sense. It might have more to do with the asyncPipe weirdness I've been seeing. Il experiment with pipeP
PR Process - PR Review Checklist
Release
Semantic release is enabled for this repository. Make sure you follow the right commit message convention.
We're using semantic-release's default — Angular Commit Message Conventions.
Description of Changes
resolves #924