refactor: StorageReader to factory #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennylavender
added a commit
that referenced
this pull request
Dec 13, 2018
lautarodragan
approved these changes
Dec 13, 2018
krobi64
suggested changes
Dec 13, 2018
There was a problem hiding this comment.
PR Review Checklist
- [n/a] Tested changes manually
- Checked accidental architectural/style changes
- Reviewed entire diff
- [n/a] Unit tests
- [n/a] Documentation
- Filenames and locations
PR Reviewer Comments
All those lets make me nervous, but I understand most of them. Only one question.
| export const StorageReader = (configuration: StorageReaderConfiguration): StorageReader => { | ||
| let mongoClient: MongoClient | ||
| let dbConnection: Db | ||
| let router: Router |
There was a problem hiding this comment.
Why does router need to be defined up here? I understand the others since they are referenced outside of the start function.
There was a problem hiding this comment.
I think he's just trying to keep the changes to the minimum, and router was defined at class level betewen dbConnection and messaging before, too.
krobi64
approved these changes
Dec 14, 2018
|
🎉 This PR is included in version 2.18.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Process - PR Review Checklist
Release
Semantic release is enabled for this repository. Make sure you follow the right commit message convention.
We're using semantic-release's default — Angular Commit Message Conventions.
Description of Changes
resolves #903