Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Insight with Bitcoin Core in BlockchainWriter #408

Merged
merged 22 commits into from
Sep 11, 2018
Merged

Replace Insight with Bitcoin Core in BlockchainWriter #408

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
764ad6c
delete useless tests
lautarodragan Sep 6, 2018
4bb4ac7
more bitcoin-core typings
lautarodragan Sep 6, 2018
b8c1c01
docker-compose bitcoin-regtest
lautarodragan Sep 6, 2018
416e841
UnspentOutput interface
lautarodragan Sep 6, 2018
a6c50c3
basic but actually working thing
lautarodragan Sep 6, 2018
ed25213
npm uninstall bitcore-lib
lautarodragan Sep 6, 2018
07451fc
npm uninstall @types/bitcore-lib
lautarodragan Sep 6, 2018
d81974d
lint
lautarodragan Sep 6, 2018
6d4c7f9
estimate fee wip
lautarodragan Sep 7, 2018
cdbe35a
revert ramda.d.ts
lautarodragan Sep 7, 2018
e47b399
improve bitcoin-core.d.ts
lautarodragan Sep 8, 2018
d9a4884
default bitcoin rpc config to regtest
lautarodragan Sep 8, 2018
9a71119
use fundrawtransaction + small refactor
lautarodragan Sep 8, 2018
e7656b2
Merge branch 'master' into bitcoin-core-writer
lautarodragan Sep 8, 2018
35c5926
rename poet-bitcoind to bitcoin-testnet in docker-compose, fix ports
lautarodragan Sep 8, 2018
cece185
Merge branch 'master' into bitcoin-core-writer
lautarodragan Sep 10, 2018
b4619ae
Merge branch 'master' into bitcoin-core-writer
lautarodragan Sep 10, 2018
e90d89a
split docker-compose.testnet
lautarodragan Sep 10, 2018
9ff3b1e
add TODO
lautarodragan Sep 11, 2018
a1ce206
add unit tests for Bitcoin.getData
lautarodragan Sep 11, 2018
8c231fa
mini fix to docker-compose.yml
lautarodragan Sep 11, 2018
0927e0c
Merge branch 'master' into bitcoin-core-writer
lautarodragan Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,21 +41,30 @@ services:
sleep 10;
npm start;
"
poet-bitcoind:
bitcoin-testnet:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the need to stand up a testnet docker instance anymore now that we are using regtest. If that is correct, can we either comment this out or remove it? Otherwise when I run docker up --build I am starting up a testnet instance and syncing with the testnet blockchain, thus using up bandwidth and storage for no real reason.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @geoffturk. I can't think of a situation that I would still want a testnet docker instance locally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, now that I thought about it more, I think we do want a mainnet/testnet instance actually for people to run the node on their machines. Maybe we just need a simpler way of expressing which instance we run instead of running all of them, but that can be tackled in a future PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, I'll split it apart in different docker-compose files. We still want to test stuff in testnet if possible, but docker up shouldn't cause you to download the whole testnet.

image: ruimarinho/bitcoin-core:0.16.2
volumes:
- bitcoind1:/home/bitcoin/.bitcoin
ports:
- "18332:18332"
- "18443:18443"
- "18444:18444"
command:
-printtoconsole
-server
-testnet=1
-rpcuser=bitcoinrpcuser
-rpcpassword=bitcoinrpcpassword
-rpcallowip=::/0
bitcoin-regtest:
image: ruimarinho/bitcoin-core:0.16.2
ports:
- "18443:18443"
command:
-printtoconsole
-server
-regtest=1
-rpcuser=bitcoinrpcuser
-rpcpassword=bitcoinrpcpassword
-rpcallowip=::/0

volumes:
bitcoind1:
Expand Down
Loading