Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: middleware transform can take ownership #963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Feb 7, 2025

This is a breaking change. But since we always use middleware.transform exactly once, take the ownership can reduce some unnecessary wrapper.

For example, a middleware can take an owned value, but since transform use &self, when decorate endpoint, you can only pass a ref of that owned value, or copy, or Arc(Mutex).

cc @sunli829 what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant