-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle unions, intersections and lists when generating sample GQL #49
Merged
cliftonmcintosh
merged 13 commits into
podium:master
from
cliftonmcintosh:cmcintosh/handle_union_and_interface_types
Jul 2, 2024
Merged
Handle unions, intersections and lists when generating sample GQL #49
cliftonmcintosh
merged 13 commits into
podium:master
from
cliftonmcintosh:cmcintosh/handle_union_and_interface_types
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliftonmcintosh
force-pushed
the
cmcintosh/handle_union_and_interface_types
branch
from
June 30, 2024 16:32
2da6473
to
76fbd01
Compare
cliftonmcintosh
changed the title
Handle unions, intersections and lists
Handle unions, intersections and lists when generating sample GQL
Jun 30, 2024
esambo
reviewed
Jul 1, 2024
Co-authored-by: E. Sambo <[email protected]>
cliftonmcintosh
commented
Jul 1, 2024
epinault
approved these changes
Jul 1, 2024
epinault
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects some problems with generation of sample GQL by handling the following return types:
Testing
I ran this on 9 repos in my organization and verified that it succeeded and the output looked correct.
Sample output
For each of these, see the updates to
schema.json
for more specifics.Unions
In this example, the return type is
LoginResponseV2
, a union ofLoginResponse
andUnexpectedRequest
.Interfaces
In this example, the return type is
Character
, which is an interface implemented byHuman
andDroid
.Lists
In this example, the return type is a list of
Droid
objects.Non-null return types
In this example, the return type is a non-null list of
Human
objects.