Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command: Revoke Sign-in Sessions. Closes #6514 #6544

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

New command: Revoke Sign-in Sessions. Closes #6514 #6544

wants to merge 3 commits into from
+389 −1

Conversation

MartinM85
Copy link
Contributor

Closes #6514

@milanholemans
Copy link
Contributor

Thank you @MartinM85, we'll try to review it ASAP!

@milanholemans
Copy link
Contributor

Hi @MartinM85, one small change in hindsight, I think we'll have to rename the option id to userId since id would reflect a session ID without the additional context in this way. Apply this change in your PR? We'll try to review it as soon as possible afterward.

@milanholemans milanholemans marked this pull request as draft January 4, 2025 12:16
@MartinM85 MartinM85 marked this pull request as ready for review January 4, 2025 17:20
@MartinM85
Copy link
Contributor Author

@milanholemans The id option renamed to userId

@milanholemans milanholemans self-assigned this Jan 4, 2025
milanholemans
milanholemans requested changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @MartinM85, I had some trouble running the command. Could you take a look at the comments I made?

src/m365/entra/commands/user/user-session-revoke.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/user/user-session-revoke.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/user/user-session-revoke.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/user/user-session-revoke.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/user/user-session-revoke.ts Outdated Show resolved Hide resolved
src/m365/entra/commands/user/user-session-revoke.spec.ts Outdated Show resolved Hide resolved
docs/docs/cmd/entra/user/user-session-revoke.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/user/user-session-revoke.mdx Show resolved Hide resolved
docs/docs/cmd/entra/user/user-session-revoke.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/entra/user/user-session-revoke.mdx Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft January 4, 2025 23:15
@MartinM85 MartinM85 marked this pull request as ready for review January 5, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans Awaiting requested review from milanholemans

Assignees

@milanholemans milanholemans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: Revoke Sign-in Sessions
2 participants
@MartinM85 @milanholemans