RS/JDJ/final renumbering

[JacksonJ-KC]

Files Changed To Support Functionality of Renumbering:

• https://github.com/pnnl/ruleset-checking-tool/blob/3fadd0946922c31fc67f69800414e0ed3d560d04/rct229/rulesets/ruleset_functions.py
• https://github.com/pnnl/ruleset-checking-tool/blob/3fadd0946922c31fc67f69800414e0ed3d560d04/rct229/ruletest_engine/ruletest_engine.py
• https://github.com/pnnl/ruleset-checking-tool/blob/3fadd0946922c31fc67f69800414e0ed3d560d04/rct229/ruletest_engine/ruletest_jsons/scripts/json_generation_utilities.py
• https://github.com/pnnl/ruleset-checking-tool/blob/3fadd0946922c31fc67f69800414e0ed3d560d04/rct229/rulesets/__init__.py
• https://github.com/pnnl/ruleset-checking-tool/blob/3fadd0946922c31fc67f69800414e0ed3d560d04/rct229/rulesets/ashrae9012019/__init__.py
• https://github.com/pnnl/ruleset-checking-tool/blob/3fadd0946922c31fc67f69800414e0ed3d560d04/rct229/web_application.py

File Changed to Support New Style of Referencing the Output2019ASHRAE901 Schema where RPD references Output2019ASHRAE901 and RMD references OutputInstance2019ASHRAE901:

• https://github.com/pnnl/ruleset-checking-tool/blob/3fadd0946922c31fc67f69800414e0ed3d560d04/rct229/schema/schema_utils.py

[JacksonJ-KC]

@jugonzal07 I am having a hard time tracing which changes to the TCD spreadsheet have test jsons that have been merged vs in open pull requests. You might find that after this branch gets merged there is some misalignment, particularly in sections 5 and 19 Rules 5-30, 19-3, 19-23, 19-37. I am trying to make sure the content of the new _renumb spreadsheets matches the masters and that we are passing CI tests.

[weilixu]

Consider this

def generate_unique_rule_id():
    """
    Generate a unique rule ID for a rule. The rule ID is generated in the format of:
    prm9012019rule + 2 digits + 1 lowercase letter + 2 digits
    """
    def generate_id():
        random_numbers12 = "".join([str(random.randint(0, 9)) for _ in range(2)])
        random_letter3 = random.choice(string.ascii_lowercase)
        random_numbers45 = "".join([str(random.randint(0, 9)) for _ in range(2)])
        return f"{random_numbers12}{random_letter3}{random_numbers45}"

    unique_rule_id = generate_id()

    # Check if the generated rule ID already exists
    while unique_rule_id in rule_map:
        unique_rule_id = generate_id()

    return f"prm9012019rule{unique_rule_id}"

[weilixu]

@JacksonJ-KC All good, ready to merge.
@jugonzal07 let me know your suggestion to Jackson's comment.

[jugonzal07]

@jugonzal07 I am having a hard time tracing which changes to the TCD spreadsheet have test jsons that have been merged vs in open pull requests. You might find that after this branch gets merged there is some misalignment, particularly in sections 5 and 19 Rules 5-30, 19-3, 19-23, 19-37. I am trying to make sure the content of the new _renumb spreadsheets matches the masters and that we are passing CI tests.

I gotcha. I'll get you a list of those changes against your renumbering. I believe nearly all should be up to date. I've kept a catalogue of the changes I've made and it shouldn't be too tough to do a comparison. All my latest changes this week have been in copies of the renumbering spreadsheet. I'll try and have that for our stand-up tomorrow.