Update Rule11-7.md #1602
Merged
Update Rule11-7.md #1602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
address possibility of propane being used instead of natural gas
KarenWGard
requested review from
JasonGlazer,
supriyagoel,
weilixu,
claperle and
JacksonJ-KC
claperle
approved these changes
Jan 22, 2025
| @@ -37,6 +37,8 @@ | |||
| - use get_SWH_components_associated_with_each_SWH_bat to get the SWH use types and SWH use in the building: `swh_bats_and_uses_b = get_SWH_components_associated_with_each_SWH_bat(B_RMD)` | |||
| - look at each SWH Equipment in the swh_bat. Appendix G requires only one system per bat, but this is covered in rule 11-8, so here we will allow multiple SWH equipment: `for swh_equip_id in swh_bats_and_uses_b[swh_bat]["SWHHeatingEq"]:` | |||
| - get the SWH equipment type using the function get_SWH_equipment_type: `swh_equip_type = get_SWH_equipment_type(B_RMD, swh_equip_id)` | |||
| - if the swh_equip type is PROPANE_INSTANTANEOUS, change it to GAS_INSTANTANEOUS for the purposes of this rule (whether Propane is an appropriate fuel source is covered in rule 11-16): `if swh_equip_type == "PROPANE_INSTANTANEOUS": swh_equip_type = "GAS_INSTANTANEOUS" | |||
| - if the swh_equip type is PROPANE_STORAGE, change it to GAS_STORAGE for the purposes of this rule (whether Propane is an appropriate fuel source is covered in rule 11-16): `if swh_equip_type == "PROPANE_STORAGE": swh_equip_type = "GAS_STORAGE" | |||
There was a problem hiding this comment.
If we see the ashrae_90_1_table_G3_1_1_2.json, all the baseline_heating_method values end with _WATER_HEATER. Should the swh_equip_type be GAS_STORAGE_WATER_HEATER?
There was a problem hiding this comment.
I think that should be fine. Recommend updating this RDS.
weilixu
approved these changes
Apr 8, 2025
| @@ -37,6 +37,8 @@ | |||
| - use get_SWH_components_associated_with_each_SWH_bat to get the SWH use types and SWH use in the building: `swh_bats_and_uses_b = get_SWH_components_associated_with_each_SWH_bat(B_RMD)` | |||
| - look at each SWH Equipment in the swh_bat. Appendix G requires only one system per bat, but this is covered in rule 11-8, so here we will allow multiple SWH equipment: `for swh_equip_id in swh_bats_and_uses_b[swh_bat]["SWHHeatingEq"]:` | |||
| - get the SWH equipment type using the function get_SWH_equipment_type: `swh_equip_type = get_SWH_equipment_type(B_RMD, swh_equip_id)` | |||
| - if the swh_equip type is PROPANE_INSTANTANEOUS, change it to GAS_INSTANTANEOUS for the purposes of this rule (whether Propane is an appropriate fuel source is covered in rule 11-16): `if swh_equip_type == "PROPANE_INSTANTANEOUS": swh_equip_type = "GAS_INSTANTANEOUS" | |||
| - if the swh_equip type is PROPANE_STORAGE, change it to GAS_STORAGE for the purposes of this rule (whether Propane is an appropriate fuel source is covered in rule 11-16): `if swh_equip_type == "PROPANE_STORAGE": swh_equip_type = "GAS_STORAGE" | |||
There was a problem hiding this comment.
I think that should be fine. Recommend updating this RDS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address possibility of propane being used instead of natural gas