-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of DAE module #93
base: master
Are you sure you want to change the base?
Conversation
j-koch
commented
Oct 2, 2023
- updates GeneralNetworkedODE class for syntax compatible with DAEs
- new GeneralNetworkedAE class for handling algebraic variable updates
- new integrator - EulerDAE
- New examples to demonstrate DAE, including black-box neural DAEs
- updated NetworkODE examples to conform to new syntax
Failed test: I suggest the DAE example in the script contains only the DAE part and not the black box NODE. I suggest we create an abstract DAESystem class to serve a similar purpose as ODESystem - no network stuff. As of now the API is unnecessarily complicated for the simple example. This is a consequence of working with the GeneralNetworkedODE class. If designed correctly, we should not need new integrator classes such as EulerDAE. I believe we should create the following classes:
|