Restructure scf conversion #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another large rework of how we convert from index tree to SCF. This is mostly contained just in how that pass is structured. Previously it was very ad-hoc, each level of the tree was converted individually. This led to problems with tracking users and with determining the loop carried arguments. The new abstractions in that pass (specifically the LoopInfo* data structure) lead to a more understandable conversion, one that should resemble the structure of passes that are written with the MLIR ConversionPatternRewriter. Because operations do not map closely from IndexTree to SCF, it is still impossible, or at least very difficult to use the ConversionPatternRewriter. These changes should also make passes like fusion easier to write with the new index tree dialect.