-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: useTexture callback parameter and behavior #1970 #2142
base: master
Are you sure you want to change the base?
Conversation
@clementroche is attempting to deploy a commit to the Poimandres Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for the PR. I have not been in the loop for Drei for a bit. And there have been some extensive changes since I will need to consult with @abernier as to why the checks are failing and if anything special is needed to merge |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Thanks for dealing with the conflicts @clementroche. I'd appreciate if you'd add me as a co-author on that particular commit. |
sure @jwueller, do you know how to do it? |
any news @FarazzShaikh @abernier @joshuaellis? |
Co-authored-by: Johannes Wüller <[email protected]>
Co-authored-by: Johannes Wüller (@jwueller) <[email protected]>
@jwueller it wasn't easy but your now co-author of those commit it seems, can you confirm? |
Sorry about the silence, I have been extremely busy recently. From what I understand, you just have to add it to the bottom of the commit message with an empty line in between.
It seems that GitHub doesn't like the
Thanks a lot! |
Fixes conflicts for #1970
cc @jwueller