Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useTexture callback parameter and behavior #1970 #2142

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

clementroche
Copy link
Contributor

Fixes conflicts for #1970

cc @jwueller

Copy link

vercel bot commented Oct 29, 2024

@clementroche is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@FarazzShaikh
Copy link
Member

Thanks for the PR. I have not been in the loop for Drei for a bit. And there have been some extensive changes since

I will need to consult with @abernier as to why the checks are failing and if anything special is needed to merge

src/core/Texture.tsx Show resolved Hide resolved
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 9:22am

Copy link

codesandbox-ci bot commented Oct 29, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@jwueller
Copy link

Thanks for dealing with the conflicts @clementroche. I'd appreciate if you'd add me as a co-author on that particular commit.

@clementroche
Copy link
Contributor Author

sure @jwueller, do you know how to do it?

@clementroche
Copy link
Contributor Author

clementroche commented Nov 7, 2024

any news @FarazzShaikh @abernier @joshuaellis?

clementroche and others added 2 commits November 7, 2024 12:31
Co-authored-by: Johannes Wüller <[email protected]>
Co-authored-by: Johannes Wüller (@jwueller) <[email protected]>
@clementroche
Copy link
Contributor Author

@jwueller it wasn't easy but your now co-author of those commit it seems, can you confirm?

@jwueller
Copy link

jwueller commented Nov 7, 2024

do you know how to do it?

Sorry about the silence, I have been extremely busy recently.

From what I understand, you just have to add it to the bottom of the commit message with an empty line in between.

can you confirm?

It seems that GitHub doesn't like the (@jwueller) part. According to https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors it expects this format:

Commit message here

Co-authored-by: Johannes Wüller <[email protected]>

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants