-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onEntityCollide function when entity are above a block #6347
base: stable
Are you sure you want to change the base?
Conversation
This does not really check if there is a collision so if there is a slab between the magma block and the player, the player will be burned. |
Thanks for the feedback, it's fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation only works for collsions on down side. An appropriate solution to the problem would be to detect when colliding with any face of the block, not just one.
Fixed |
$block = $entityBlock->getSide($face); | ||
foreach ($block->getCollisionBoxes() as $blockBox) { | ||
if ($entityBox->intersectsWith($blockBox)) { | ||
$block->onEntityCollide($this, Facing::opposite($face)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this case add this?
$hasUpdate = true;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be but if i realy good understand, hasUpdate
variable is set to true only if entity is update. However, in function onCollide
, we are not sure that entity is update.
So, i don't realy sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look OK to me
Introduction
PocketMine don't have function to detect if an entity are above a block.
So i add a function and fix the bug with magma block.
But there are other bug of this type (with top of cactus...), so i must to be fix in this pr or open an other pr to fix them ?
Relevant issues
Fix #2041
Changes
API changes
Add
Block::onEntityCollide()
Follow-up
Tests
Add-Magma-Block-PMMP.mp4