Implemented Composter #4742
Open
Implemented Composter #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tests/phpunit/block/block_factory_consistency_check.json
|
Stop being needy. There is not enough reviewer manpower to go around and I have much more important things to worry about right now. I'll review it when I have the available time. |
dktapps
added
Category: Gameplay
# Conflicts: # src/VersionInfo.php # tests/phpunit/block/block_factory_consistency_check.json
dktapps
added
Type: Enhancement
NTT1906
added a commit
to NTT1906/dump
that referenced
this pull request
Jul 19, 2023
NTT1906
added a commit
to NTT1906/dump
that referenced
this pull request
Jul 19, 2023
|
@ShockedPlot7560 Should I add events? |
Probably yes |
Co-authored-by: ShockedPlot7560 <[email protected]>
Co-authored-by: ShockedPlot7560 <[email protected]>
|
@ShockedPlot7560 I don't know what I was thinking before deciding to use SingletonTrait, should CompostFactory be shifted to static instead of Singleton? |
|
Singleton is ok |
Joshy3282
added a commit
to Joshy3282/PocketMine-MP
that referenced
this pull request
Oct 2, 2024
…to composter-new # Conflicts: # src/block/BlockTypeIds.php # src/data/bedrock/block/convert/BlockObjectToStateSerializer.php # src/data/bedrock/block/convert/BlockStateToObjectDeserializer.php # tests/phpunit/block/block_factory_consistency_check.json
NTT1906
commented
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Add composter, again... This is a copy of 4740
Relevant issues
N/A
Changes
Tests
Video