Skip to content

Commit

Permalink
Move keyring configuration in tests out of root's ~/.rpmmacros
Browse files Browse the repository at this point in the history
Keyring type is not something that would be user-specific in a real
world scenario anyhow.

The third step to fixing rpm-software-management#3521
  • Loading branch information
pmatilai committed Jan 20, 2025
1 parent 7c8302b commit 8bbf464
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 10 deletions.
3 changes: 1 addition & 2 deletions tests/rpmdb.at
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ AT_KEYWORDS([rpmdb query])
AT_SKIP_IF([test x$PGP = xdummy])
RPMDB_INIT

# root's .rpmmacros used to keep this build prefix independent
echo "%_keyring rpmdb" >> "${RPMTEST}"/root/.rpmmacros
echo "%_keyring rpmdb" >> "${RPMTEST}"/"${RPMSYSCONFDIR}"/macros.keyring

RPMTEST_CHECK([
runroot rpm -U --nodeps --ignorearch --ignoreos --nosignature \
Expand Down
12 changes: 4 additions & 8 deletions tests/rpmsigdig.at
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ AT_SETUP([rpmkeys key update and delete (rpmdb)])
AT_KEYWORDS([rpmkeys signature])
RPMDB_INIT
# currently the default but make it explicit
# root's .rpmmacros used to keep this build prefix independent
echo "%_keyring rpmdb" >> "${RPMTEST}"/root/.rpmmacros
echo "%_keyring rpmdb" >> "${RPMTEST}"/"${RPMSYSCONFDIR}"/macros.keyring
RPMTEST_CHECK([
runroot rpmkeys --import /data/keys/rpm.org-rsa-2048-test.pub
runroot rpmkeys -Kv /data/RPMS/hello-2.0-1.x86_64-signed-with-new-subkey.rpm
Expand Down Expand Up @@ -164,8 +163,7 @@ RPMTEST_CLEANUP
AT_SETUP([rpmkeys migrate from keyid to fingerprint (fs)])
AT_KEYWORDS([rpmkeys rpmdb])
RPMDB_INIT
# root's .rpmmacros used to keep this build prefix independent
echo "%_keyring fs" >> "${RPMTEST}"/root/.rpmmacros
echo "%_keyring fs" >> "${RPMTEST}"/"${RPMSYSCONFDIR}"/macros.keyring
krpath="$(rpm --eval %{_keyringpath})"

RPMTEST_CHECK([
Expand Down Expand Up @@ -199,8 +197,7 @@ RPMTEST_CLEANUP
AT_SETUP([rpmkeys key update (fs)])
AT_KEYWORDS([rpmkeys signature])
RPMDB_INIT
# root's .rpmmacros used to keep this build prefix independent
echo "%_keyring fs" >> "${RPMTEST}"/root/.rpmmacros
echo "%_keyring fs" >> "${RPMTEST}"/"${RPMSYSCONFDIR}"/macros.keyring
RPMTEST_CHECK([
runroot rpmkeys --import /data/keys/rpm.org-rsa-2048-test.pub
runroot rpmkeys -Kv /data/RPMS/hello-2.0-1.x86_64-signed-with-new-subkey.rpm
Expand Down Expand Up @@ -278,8 +275,7 @@ RPMTEST_CLEANUP
AT_SETUP([rpmkeys key update (openpgp)])
AT_KEYWORDS([rpmkeys signature])
RPMDB_INIT
# root's .rpmmacros used to keep this build prefix independent
echo "%_keyring openpgp" >> "${RPMTEST}"/root/.rpmmacros
echo "%_keyring openpgp" >> "${RPMTEST}"/"${RPMSYSCONFDIR}"/macros.keyring
krpath=$(rpm --eval "%{_keyringpath}")

RPMTEST_CHECK([
Expand Down

0 comments on commit 8bbf464

Please sign in to comment.