Bugfix: removed pdb breakpoint from exception handling #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkpr Thanks, James. I didn't think you still had permissions to I also had: But I just closed it for now. I may or may not work on little things if I have time, and I was planning to bundle all of them in a big PR as well, as I was expecting these PRs to stay open for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request addresses any open issues, please link them here.
#50
What has been done to verify that this works as intended?
Replicating the upload that caused it in the first place.
How could this contribution be further improved? Were any other approaches considered?
No. Exceptions should be fixed on a case by case basis. But this was causing a blanket issue for any exception.