Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: removed pdb breakpoint from exception handling #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joeflack4
Copy link
Contributor

If this pull request addresses any open issues, please link them here.

#50

What has been done to verify that this works as intended?

Replicating the upload that caused it in the first place.

How could this contribution be further improved? Were any other approaches considered?

No. Exceptions should be fixed on a case by case basis. But this was causing a blanket issue for any exception.

Copy link

@jkpr jkpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeflack4
Copy link
Contributor Author

@jkpr Thanks, James. I didn't think you still had permissions to pmaengineering.

I also had:

But I just closed it for now. I may or may not work on little things if I have time, and I was planning to bundle all of them in a big PR as well, as I was expecting these PRs to stay open for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants