Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrow API update & Security #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Borrow API update & Security #13

wants to merge 3 commits into from

Commits on Apr 24, 2019

  1. Fixed security vulnerabilities

    @joeflack4
    joeflack4 authored Apr 24, 2019
    Configuration menu
    Copy the full SHA
    4024f52 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Developer updates 

    - Exposed ArgumentParser object as 'parser' to Borrow API by moving it to global scope of module. Rationale is to allow for use with ArgeparseToWebform.
- Renamed CLI option 'xlsxfile' to 'xlsxfiles' to make consistent with the Python API.
- Altered Python API borrow() function definition. Removed unneeded *. Changed optional params to default to None or False. Strongly coupled CLI and Python API parameter interface by requiring CLI parameters passed to be exactly the same, via dynamically loading list of attribute names from the borrow() function definition.
    @joeflack4
    joeflack4 committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    852bc6a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. Developer updates 

    - Refactored borrow_cli() function to be much cleaner.
- Re-added leading * to borrow() function definition to require keyword args.
- Removed parser obj from global module variable in favor of cli_parser() constructor.
- Updated .gitignore
    @joeflack4
    joeflack4 committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    cba1a20 View commit details
    Browse the repository at this point in the history