Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google Cloud Storage bucket uploads #94

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Conversation

mattes
Copy link
Contributor

@mattes mattes commented Jan 16, 2025

Changes in this PR:

  • move *.wasm file into parent, delete *_js directory.
  • Increase artifact lifespan to 14 days
  • Release workflow also uploads to Google Cloud Storage bucket

Files uploaded to Google Cloud Storage bucket are individually gzip'ed with flag -7 to go with a slightly higher/ better compression at the cost of decompression speed. The gzip default is 6 btw.

Files can be accessed via https://web-prover-circuits.pluto.xyz/<git-hash>/file. An example URL format would be:

https://web-prover-circuits.pluto.xyz/4e342aa123f1ba339875d5efacb4c9b225b3f6ec/http_verification_1024b.bin

When a browser requests a file, it typically includes the header Accept-Encoding: gzip. In response, the server returns the gzipped content, which the browser automatically decompresses on the fly and presents to the developer as an uncompressed file.

Similarly, a non-browser client should include the Accept-Encoding: gzip header in its request to download the gzipped file. If this header is not included, Google Cloud Storage will serve the decompressed version of the file.

To illustrate this behavior more clearly, consider the following examples:

# Download the gzipped file
curl -v "https://web-prover-circuits.pluto.xyz/<githash>/http_verification_1024b.bin" -H "Accept-Encoding: gzip" > http_verification_1024b.bin.gz

# Download the decompressed file
curl -v "https://web-prover-circuits.pluto.xyz/<githash>/http_verification_1024b.bin" > http_verification_1024b.bin

Closes #92

@mattes mattes changed the title Google Cloud Storage bucket uploads feat: Google Cloud Storage bucket uploads Jan 16, 2025
@mattes mattes marked this pull request as ready for review January 17, 2025 00:20
@mattes mattes requested a review from Autoparallel January 17, 2025 00:20
@mattes mattes self-assigned this Jan 17, 2025
@mattes mattes added feature ✨ New feature or core functionality refactor 📦 Structural but nor logical changes Continuous Integration 🐲 Build and CI pipeline release 🚀 and removed refactor 📦 Structural but nor logical changes labels Jan 17, 2025
@devloper devloper self-requested a review January 17, 2025 01:02
Copy link
Contributor

@devloper devloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattes mattes merged commit 12eb3a0 into main Jan 17, 2025
3 checks passed
@mattes mattes deleted the feat/storage_bucket branch January 17, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Continuous Integration 🐲 Build and CI pipeline feature ✨ New feature or core functionality release 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Upload individual artifacts to Google Cloud Storage
2 participants