Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny rsa #68

Merged
merged 28 commits into from
May 31, 2024
Merged

Tiny rsa #68

merged 28 commits into from
May 31, 2024

Conversation

0xJepsen
Copy link
Contributor

@0xJepsen 0xJepsen commented May 16, 2024 •
edited
Loading

This isn't necessarily in the scope but peaked my interest.

Will close #73

One thing to be done on this would be to implement an algorithm for generating large primes and upgrade from tiny_rsa -> big rsa

Autoparallel and others added 25 commits May 15, 2024 15:59
@Autoparallel
feat: basic setup
e23bf01
@Autoparallel
add: README in curve module
669cea5
@Autoparallel
impl Tonelli-Shanks sqrt
9ea0233
@Autoparallel
feat: 17-torsion generators
6bd95b0
@Autoparallel
bug: curve::tests::fields::double_distorted_generator() fails
9c90a02
@Autoparallel
fix: GaloisField<2, 59>::inverse()
be464e2
@Autoparallel
feat: vertical line functions
dcc5805
@Autoparallel
fix: lhs scalar mul
b513b90
@Autoparallel
feat: tangent line
e143352
@Autoparallel
test: line_from_p_to_2p
c568e18
@Autoparallel
fix: point_doubling()
055df04
@Autoparallel
bug: miller_loop_check() does not pass yet
957ac6c
@Autoparallel
fix: panic!s on AffinePoint::Infinity
800e1ba
@Autoparallel
wip
57d71e6
@0xJepsen
wip: working tiny rsa
6c4e368
@0xJepsen
wip: working tiny rsa
13b6f13
@Autoparallel
feat: miller loop test passes
90d1b58
@Autoparallel
update generator
9781e75
@Autoparallel
cleanup pairing
d706c7f
@Autoparallel
clean lint
1db5b3c
@0xJepsen
Merge branch 'feat/pairing' into tiny_rsa
e1a2e81
@0xJepsen
feat: use our field trait
f388f53
@0xJepsen
chore: todo comments
68072a8
@0xJepsen
feat: tiny_rsa
96a583e
@0xJepsen
Merge branch 'main' into tiny_rsa
c789f6a
@0xJepsen 0xJepsen marked this pull request as ready for review May 20, 2024 21:51
@Autoparallel
Copy link
Contributor

Why not just use the PrimeField struct here instead of creating a whole new struct?

Autoparallel
Autoparallel reviewed May 21, 2024
View reviewed changes
src/tiny_rsa/mod.rs Show resolved Hide resolved
src/tiny_rsa/mod.rs Outdated Show resolved Hide resolved
@0xJepsen
Copy link
Contributor Author

Why not just use the PrimeField struct here instead of creating a whole new struct?

because the field is not prime!

@0xJepsen 0xJepsen requested a review from Autoparallel May 30, 2024 18:22
@Autoparallel
Copy link
Contributor

Why not just use the PrimeField struct here instead of creating a whole new struct?

because the field is not prime!

Then it is a ring not a field! Has to be of prime power order to be a field.

Autoparallel
Autoparallel approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's everything i've ever dreamed of and more

@Autoparallel Autoparallel merged commit 9f85c94 into main May 31, 2024
4 checks passed
@Autoparallel Autoparallel deleted the tiny_rsa branch May 31, 2024 17:27
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Autoparallel Autoparallel Autoparallel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Tiny RSA
2 participants
@0xJepsen @Autoparallel