Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dockerfile to use nonroot user by default #373

Closed
wants to merge 1 commit into from
Closed

Update dockerfile to use nonroot user by default #373

wants to merge 1 commit into from

Conversation

floreks
Copy link
Member

@floreks floreks commented Jul 19, 2022

Summary

As in the title.

Test Plan

make build and docker run ....

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

michaeljguarino
michaeljguarino reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should definitely test this before pushing. I'm not sure what the most natural approach would be but one could just be to create a shadow deployment of the plural api in our cluster

@davidspek davidspek self-assigned this Nov 10, 2022
@davidspek
Copy link
Contributor

Closing in favor of #874 which has been deployed and tested.

@davidspek davidspek closed this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino left review comments

Assignees

@davidspek davidspek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floreks @davidspek @michaeljguarino