Show a clear error message when user has no permission to delete pod #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,7 +63,7 @@ export function DeleteJob({ name, namespace, refetch }) { | |||
| /> | |||
| {confirm && ( | |||
| <Confirm | |||
| description="The pod will be replaced by it's managing controller" | |||
| description="The pod will be replaced by it's managing controller. Note: You need the ADMIN/DELETE role to perform this action." | |||
There was a problem hiding this comment.
What I'd add here is error handler for mutation above. Because now it's still not clear if any error occurred. Just a simple banner or something like in other places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
So after investigation I've decided on a simple message
Note: ...instead of a full role checking for three reasons:fetchMore) before informing the user.Labels
Test Plan
Checklist