Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 compatibility #12

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Python 3 compatibility #12

wants to merge 12 commits into from

Conversation

natebragg
Copy link
Collaborator

Done in stages, to help make clear the nature of each change.

I tested with:

python -m test.test_mini
python -m test.test_new_ast
python -m test.test_java
python -m test.test_java_precisely

Then I did the same with python3, and then compared the output.

The specific versions tested were 2.7.15rc1 and 3.6.7.

@natebragg
Copy link
Collaborator Author

With these last few changes, I have now also verified it against all the tests in test_axioms (or at least the ones that were passing before).

@natebragg natebragg force-pushed the py3port branch 2 times, most recently from ba1d5c4 to 599a295 Compare May 1, 2019 18:28
natebragg added 12 commits May 15, 2019 17:29
@natebragg
Python 2/3 port of jsketch, using modernize -x map -x filter --no-six
b151ce4
@natebragg
Handle OSError raised when missing '/usr/libexec/java_home'
3c42431
@natebragg
Hacks around python 2/3 unicode difference.
9c4c11e 
This code seems to rely pretty heavily on nuances of string encodings, and
without being sure of exactly how, it seems safer just to work around it.
@natebragg
Hacks around python 2/3 missing imports.
52f5e9b
@natebragg
Port map/filter for python 2/3, using modernize -f map -f filter
e9d3e18 
Turns out this was necessary after all, because python 3 map and filter return
iterators, not lists.
@natebragg
Hacks around python 2/3 xrange.
bf4a68e
@natebragg
Force int conversion, for python 3 compatibility.
165737a
@natebragg
A couple more python 3 nuances.
cbfd2af 
The `universal_newlines` flag is ignored by python 2, but without it, python 3
yields a bytestring here, which is a monkey wrench in whatever uses the result.

The call to "zip" in python 3 yields an iterator, which can only be consumed
once, and isn't memoized, so the subsequent uses of `cls` fail to do anything.
@natebragg
Silence deprecation warnings due to a python 3 change to modifier syn…
79b53a2 
…tax.
@natebragg
Typo.
5eb60f9
@natebragg
Some more python 3 compatibility changes.
298bb57 
Avoiding name shadowing, iterating a changing structure, and concatenating
dictionaries.
@natebragg
Re-encode as utf8, so open() in python 3 doesn't reject it.
39fd618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@natebragg