Use cimg/node instead of circleci/node#7080
Conversation
|
Hmm, this didn't see to help. The karma-firefox-launcher is also deprecated, in fact all of karma is, so time is maybe better spent upgrading to something else, than trying to fix it, since a bug-fix wouldn't be merged even if we found an upstream issue. |
8dc8110 to
5ab9514
Compare
|
I don't see last CircleCI run. |
|
I don't have permission to manually trigger a run, and i don't know why my commits didn't trigger. I can try again today ofc. |
|
Please add a newline to |
|
Could you please fix the errors here? |
7d1d447 to
49c3032
Compare
|
FYI - Some of our mathjax tests started failing after Firefox v82. So we had to add those specific version tests. |
|
It's not fixed in Firefox - had a test break. It's open here https://bugzilla.mozilla.org/show_bug.cgi?id=1350755 |
|
Looking good. Let me re-run the image test. |
|
@birkskyum Before I merge, are you happy with the updates in this PR or do you want to add additional commits? |
|
I'm okay with its current state |
archmoj
left a comment
There was a problem hiding this comment.
It's not always easy to bump dependencies.
💃
Thanks very much for the PR.
As mentioned here:
This is still Node 16, but using the cimg/node as a step towards:
node.js v18andnpm v10in development #7078Related to