feat: parallelize copy/client.ImageExistsAtRemote calls #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
commented
Mar 31, 2023
aslafy-z
commented
Mar 31, 2023
|
@jpreese Here you go, you can check the result at: https://github.com/aslafy-z/sinker/releases/tag/v0.19.0-rc.1 |
aslafy-z
commented
Apr 26, 2023
| @@ -33,9 +34,21 @@ func New(logInfo func(format string, args ...interface{})) (Client, error) { | |||
| return Client{}, fmt.Errorf("new docker client: %w", err) | |||
| } | |||
|
|
|||
| remoteOptions := []remote.Option{ | |||
| remote.WithAuthFromKeychain(authn.DefaultKeychain), | |||
| remote.WithRetryBackoff(remote.Backoff{ | |||
There was a problem hiding this comment.
Add 429 retry code google/go-containerregistry#1635
| @@ -33,9 +34,21 @@ func New(logInfo func(format string, args ...interface{})) (Client, error) { | |||
| return Client{}, fmt.Errorf("new docker client: %w", err) | |||
| } | |||
|
|
|||
| remoteOptions := []remote.Option{ | |||
| remote.WithAuthFromKeychain(authn.DefaultKeychain), | |||
| remote.WithRetryBackoff(remote.Backoff{ | |||
There was a problem hiding this comment.
Check what's the status of the withRetryBackoff pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
For 800 images:
Before: 3m21s
After: 10s
This depends on google/go-containerregistry#1628. At least, backoff strategy will not be applied before that PR is released.