Skip to content

Commit

Permalink
Merge pull request #3443 from plentymarkets/fix/recaptcha_cookie_defa…
Browse files Browse the repository at this point in the history
…ult_optout

fix: recaptcha loading without consent
  • Loading branch information
stentrop authored Oct 26, 2023
2 parents 68d8867 + 885e928 commit c2a6197
Show file tree
Hide file tree
Showing 211 changed files with 463 additions and 331 deletions.
74 changes: 63 additions & 11 deletions config.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,48 @@
"defaultValue": 0.5
}
},
"global.google_recaptcha_consentGroup": {
"type": "selectBox",
"required": false,
"label": "Config.globalGoogleRecaptchaConsentGroupLabel",
"options": {
"defaultValue": "media",
"selectBoxValues": [
{
"value": "necessary",
"caption": "Config.globalGoogleRecaptchaConsentGroupNecessary"
},
{
"value": "tracking",
"caption": "Config.globalGoogleRecaptchaConsentGroupTracking"
},
{
"value": "marketing",
"caption": "Config.globalGoogleRecaptchaConsentGroupMarketing"
},
{
"value": "media",
"caption": "Config.globalGoogleRecaptchaConsentGroupMedia"
}
]
}
},
"global.google_recaptcha_consentNecessary": {
"type": "checkBox",
"required": false,
"label": "Config.globalGoogleRecaptchaConsentNecessaryLabel",
"options": {
"defaultValue": "false"
}
},
"global.google_recaptcha_consentOptOut": {
"type": "checkBox",
"required": false,
"label": "Config.globalGoogleRecaptchaConsentOptOutLabel",
"options": {
"defaultValue": "false"
}
},
"global.user_data_hash_max_age": {
"type": "selectBox",
"required": false,
Expand Down Expand Up @@ -4089,7 +4131,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityBackOrder"
}
Expand Down Expand Up @@ -4142,7 +4185,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4195,7 +4239,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4248,7 +4293,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4301,7 +4347,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4354,7 +4401,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4407,7 +4455,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4460,7 +4509,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4513,7 +4563,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -4566,7 +4617,8 @@
{
"value": "https://schema.org/SoldOut",
"caption": "Config.availabilitySoldOut"
}, {
},
{
"value": "https://schema.org/BackOrder",
"caption": "Config.availabilityInStock"
}
Expand Down Expand Up @@ -5110,4 +5162,4 @@
}
}
}
}
}
10 changes: 9 additions & 1 deletion meta/documents/changelog_de.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,17 @@

### Geändert

- Um die schema.org-Daten [SalesPrice](https://schema.org/SalePrice) und [ListPrice](https://schema.org/ListPrice) auf der Artikeldetailseite auszugeben ist es nicht mehr notwendig, an der Variante die Option **Grundpreis anzeigen** zu aktivieren.
- Um die schema.org-Daten [SalesPrice](https://schema.org/SalePrice) und [ListPrice](https://schema.org/ListPrice) auf der Artikeleinzelansicht auszugeben, ist es nun nicht mehr notwendig, an der Variante die Option **Grundpreis anzeigen** zu aktivieren.
- Google reCAPTCHA wird nicht mehr ohne die entsprechende Cookie-Einwilligung geladen.
- Die Englische Übersetzung für den Übersetzungsschlüssel `checkoutBuyNow` wurde von "Order now" zu "Buy" geändert.

### Hinzugefügt

- Das Google reCAPTCHA Cookie hat neue Einstellungsoptionen:
- Setzen in einer bestimmten Cookie-Gruppe: Essenziell, Statistik, Marketing oder Externe Medien.
- "Als notwendigen Cookie registrieren": Das Cookie kann vom User nicht abgewählt werden.
- "Als Opt-Out registrieren": Cookie ist vorausgewählt und muss aktiv abgewählt werden.

### Behoben

- Auf Geräten mit iOS Versionen <= 12.x wurden bei deaktiviertem SSR und Verwendung von ShopBuilder-Inhalten bestimmte Elemente nicht geladen. Wir möchten uns bei @KarolKski für den Beitrag bedanken.
Expand Down
10 changes: 9 additions & 1 deletion meta/documents/changelog_en.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,17 @@

### Changed

- To show the schema.org data for [SalesPrice](https://schema.org/SalePrice) and [ListPrice](https://schema.org/ListPrice), it's no longer necessary to activate the **Show unit price** option of the variation.
- To show the schema.org data for [SalesPrice](https://schema.org/SalePrice) and [ListPrice](https://schema.org/ListPrice), it is no longer necessary to activate the **Show unit price** setting of the variation.
- Google reCAPTCHA will not be loaded without the corresponding cookie consent.
- The English translation for the translation key `checkoutBuyNow` has been changed from "Order now" to "Buy".

### Added

- The Google reCAPTCHA cookie has the following new settings:
- Set in a specific cookie group: Essential, Statistics, Marketing or External Media.
- “Register as a necessary cookie”: The cookie cannot be deselected by the user.
- "Register as opt-out": Cookie is preselected and must be actively deselected.

### Fixed

- On devices with iOS versions <= 12.x, certain elements were not loaded when SSR was disabled and ShopBuilder contents were used. We would like to thank @KarolKski for the contribution.
Expand Down
14 changes: 11 additions & 3 deletions resources/js/dist/ceres-base.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion resources/js/dist/ceres-base.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions resources/js/dist/ceres-base.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/ceres-base.min.js.map

Large diffs are not rendered by default.

14 changes: 11 additions & 3 deletions resources/js/dist/ceres-checkout.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion resources/js/dist/ceres-checkout.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions resources/js/dist/ceres-checkout.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/ceres-checkout.min.js.map

Large diffs are not rendered by default.

14 changes: 11 additions & 3 deletions resources/js/dist/ceres-client.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion resources/js/dist/ceres-client.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions resources/js/dist/ceres-client.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/ceres-client.min.js.map

Large diffs are not rendered by default.

Loading

0 comments on commit c2a6197

Please sign in to comment.