-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prefer-locator): Add rule to suggest not using page methods #315
feat(prefer-locator): Add rule to suggest not using page methods #315
Conversation
This rule should be more generic for all page actions that are like it. For example click is the same exact way |
Looks like their a quite a few Page methods tagged with NOTE Use locator-based now that you mention it
I'll extend it to those |
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This also closes #197 |
This rule detects where page.fill(loc, value) has been used and suggests the user uses a locator based fill as per the documentation for page.fill
https://github.com/microsoft/playwright/blob/d1926e2f9b91e31d73acfb87e564634f55b0dbb2/docs/src/api/class-page.md?plain=1#L2027