Fix issue #1463 by restoring behavior of --timeout parameter #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to python3 broke the processing of the --timeout parameter due to a type mismatch (a string was compared to an integer). The fix is to always treat the --timeout parameter as a string, deferring to the test runner to parse it and report errors. This also fixes a typo in the name of a variable "webclient_timeout" (it was named "weblcient_timeout"). It also adds some new regression tests for the auto-test functionality.
The win32 checks report a failure in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful things
Fixes
Fixes #1463
Purpose
The upgrade to python3 broke the processing of the --timeout parameter due to a type mismatch (a string was compared to an integer). The fix is to always treat the --timeout parameter as a string, deferring to the test runner to parse it and report errors.
This also fixes a typo in the name of a variable "webclient_timeout" (it was named "weblcient_timeout").
It also adds some new regression tests for the
play auto-testcommand.