Updated 3rd party dependencies #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is compiling successfully using JDK 20 so maybe the minimum JDK has been increased and the following libs must be reverted to 3.33.0. More investigation is needed. |
|
@xael-fry I've confirmed that Eclipse JDT compiler v0.33.0 is the last version supporting Java 11 and Java 17 is the new minimum for later compiler versions. Otherwise, this is good to go. Cheers |
This supports Java 20
…for JDK 11" This reverts commit 663a132.
|
Confirmed again that post JDT v3.33.0 versions (in this case v3.35.0) do not work with Java 11. It would be nice if the Java 17 builds would happen even if the Java 11 build fails to show that it does work for later versions of Java
|
xael-fry
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass