-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bun build support #7242
Bun build support #7242
Conversation
Can you add some context about the motivation for this PR please? |
So what's the Bun lockfile? How and when does it get updated? |
So the bun lockfile works the same as package-lock.json but instead of being a json object its a binary. |
I expressed some concern to ChatGPT for its take and it chimed with what I was thinking:
If you're using a submodule, can't you use a local override or generate a file into your submodule with a pre-build step or something? |
So I've tested building the engine with bun and that works fine too with the same package lock. Yes you do not need to have bun lock file but for installation performance it's advised to have it by Bun themselves. As for the using the engine as a sub module the types scoping is required regardless as types of the sub module will conflict is you are using a different runtime in the engine to your parent project. |
Can we compromise on the types update then and back out the bun lockfile for now? |
Yep that works for me |
This PR stems from attempting to build the engine from source as a submodule within a bun-based project. Ideally, the engine should be able to be built in bun successfully as a submodule without conflicting with the parent project node module types.
Overview