[DO NOT MERGE] Rendering to texture reflection issue #7191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #7183
This is just a render-to-texture example updated with multiple meshes, and the camera which renders to texture no longer orbits but matches the main camera. We should expect the image that gets rendered to the texture matches the main framebuffer.
All other meshes render correctly, both the IBL reflection as well as specular from the light, but the original mesh from the issues has those incorrectly rendered.
As mentioned, the IBL part at least can be "fixed" by inverting normal or view vector used by fresnel calculation, but that breaks all other meshes.
So it's somehow specific to that one mesh. So far I was not successful finding out what it is - normals seems fine.
Creating this PR in case we at some point get to investigate it again. It will also give us a deployed link for further testing (https://engine-mummlbpju-playcanvas.vercel.app/#/graphics/render-to-texture)