Migrate from Terser and Babel to SWC #6920
Open
+537
−5,921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any change to sizes? |
|
Also is there a difference in ECMA compliance, if there is a difference between ES5 versio s, and what it results in? |
|
It has the same targets for both UMD and ES builds, so should match current
outputs.
I need to adjust some settings to get the build size back in line though,
so consider this draft for now.
…On Fri, 6 Sep 2024 at 18:15, mrmaxm ***@***.***> wrote:
Also is there a difference in ECMA compliance, if there is a difference
between ES5 versio s, and what it results in?
—
Reply to this email directly, view it on GitHub
<#6920 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJFLFPULMRTOP2IBLJDHTZVHPLDAVCNFSM6AAAAABNY3P7G2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUGQ4TGNBTGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
If it is not possible to bring the build size to what terser is capable of, then we can consider to use this for a debug build, as it is usually the one that takes the most of the time during development and its size is of less importance. |
|
Below are the file sizes. Will continue investigating
|
package.json
Outdated
| "@rollup/plugin-terser": "^0.4.4", | ||
| "@rollup/pluginutils": "^5.1.0", | ||
| "c8": "^10.1.2", | ||
| "@swc/core": "^1.7.23", | ||
| "c8": "^9.1.0", |
There was a problem hiding this comment.
How come c8 was bumped down in this PR?
|
The wins from this look extremely compelling. I'd be supportive of switching. |
- Added "peer": true to several existing dependencies to indicate peer dependencies. - Introduced new modules: jackspeak (v3.4.3) and package-json-from-dist (v1.0.1) with their respective details. - Added path-scurry (v1.11.1) and its dependency lru-cache (v10.4.3) with funding information. These changes enhance dependency management and ensure compatibility with peer dependencies.
- Eliminated the babel-parser dependency from the ESLint configuration file. - Updated the parser options to ensure compatibility with the existing setup. These changes streamline the ESLint configuration and reduce unnecessary dependencies.
- Changed the import name of the SWC plugin from 'swc' to 'swcPlugin' for clarity. - Updated all instances in the buildTarget function to use the new import name. These changes improve code readability and maintainability.
- Removed several unused Babel-related dependencies from package.json and package-lock.json to streamline the project. - Updated the package-lock.json to reflect the removal of these dependencies and added optional flags where applicable. - Enhanced dependency management by ensuring that only necessary modules are retained, improving overall project maintainability.
… rollup-spaces-to-tabs.mjs - Deleted the rollup-script-target.mjs file, streamlining the build process. - Updated swcOptions to ensure comments are preserved in the output when not minifying. - Clarified documentation in rollup-spaces-to-tabs.mjs regarding the plugin's functionality. These changes enhance code maintainability and improve the clarity of the build configuration.
…ting - Adjusted the formatting of the `pure_funcs` array in the `swcOptions` function to ensure consistency. - This change enhances code readability and maintains the existing functionality of the build configuration.
- Upgraded the version of the 'playcanvas' package from 2.3.0-dev to 2.4.0-dev. - Updated several dependencies, including '@webgpu/types' from ^0.1.40 to ^0.1.52, and '@playcanvas/eslint-config' from ^2.0.2 to ^2.0.8. - Removed multiple unused rebuild package lock
…s for Rollup. See vitejs/vite#15532 - Added optional dependencies for various Rollup packages, including support for multiple platforms (Linux, Darwin, FreeBSD, Windows). - Updated package-lock.json to reflect the addition of these optional dependencies and their respective versions. - This change enhances cross-platform compatibility and ensures that the build process can leverage the appropriate Rollup binaries as needed.
…lated dependencies - Upgraded @swc/core to version 1.10.1 and updated its dependencies across various platforms. - Removed the optional dependency for @rollup/rollup-linux-x64-gnu. - Updated @swc/types to version 0.1.17 for improved compatibility. - These changes enhance the project's build capabilities and ensure better support for the latest SWC features.
|
Comparison of Existing Build System vs SWC
Observations
|
willeastcott
changed the title
Comment on lines
17
to
19
| parserOptions: { | ||
| requireConfigFile: false | ||
| }, |
There was a problem hiding this comment.
If we don't need the Babel parser any more, can we also drop parserOptions? I think we only added this for Babel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces Babel + Terser with SWC which improves the build time of each target.
The same ES5 targets are used for UMD build outputs.
With Terser/Babel ~ 1m40s
With SWC ~ 51s
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.