-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebXR Persistent Anchors #5779
Merged
Merged
WebXR Persistent Anchors #5779
+900
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you please resolve conflicts here @Maksims |
mvaligursky
reviewed
Nov 7, 2023
mvaligursky
reviewed
Nov 7, 2023
mvaligursky
reviewed
Nov 7, 2023
mvaligursky
reviewed
Nov 7, 2023
mvaligursky
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid, just few small suggestions.
mvaligursky
reviewed
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5698
This PR adds new APIs to Anchors, that allows to persist them across sessions within page origin.
Meta Quest 3 has support of such feature.
Through my quick testing, atm Quest 3 supports up to 8 persistent anchors per origin.
Test link: https://examples.playcanvas.meta.space/#/xr/ar-anchors-persistent
New APIs:
This PR requires this: #5778 to be merged first.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.