Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JACOBIN-645 throw.go, frames.go, interpreter.go #275

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

texadactyl
Copy link
Collaborator

@texadactyl texadactyl commented Jan 31, 2025

frames.FormatFQN:

// From the given frame, return the FQN as a formatted string.
func FormatFQN(fr *Frame) string {
	return fmt.Sprintf("%s.%s%s", util.ConvertInternalClassNameToUserFormat(fr.ClName), fr.MethName, fr.MethType)
}

throw.go: amended to use FormatFQN consistently.

interpreter.go: amended to rely on ThrowEx to supply FQN information.

Also, remove redundant FQN announcement in:

  • gfunction/gfunctionExec.go
  • native/nativeFuncExec.go

NOTE: run.go runThread untrapped panic handling has not yet been addressed.

@texadactyl
Copy link
Collaborator Author

texadactyl commented Jan 31, 2025

@texadactyl
Copy link
Collaborator Author

Giddyap, Windows!

@platypusguy platypusguy merged commit aefd0e5 into platypusguy:main Feb 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants