Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commit parsing and improve error handling in pull-platformplatform-changes CLI command #688

Merged

Conversation

tjementum
Copy link
Member

@tjementum tjementum commented Feb 3, 2025

Summary & Motivation

Fix multiple issues in the pull-platformplatform-changes CLI command on Windows:

  • Commit parsing failed due to incorrect handling of new line characters. Previously, the command split Git output using Environment.NewLine, which worked on Mac but not on Windows, where Git outputs \n instead of \r\n. This has been corrected to ensure proper commit recognition across operating systems.
  • Fix an issue where parsing pull request descriptions containing double quotation marks (") caused the command to exit without an error. The CLI now correctly handles these cases.
  • Improve error handling by adding a proper error message when pushing changes to origin fails, providing better feedback to the user.

Additionally, fix a bug in the install command on newly installed macOS systems. Previously, the installation failed if the shell configuration files for ZSH or Bash did not exist.

Checklist

  • I have added tests, or done manual regression tests
  • I have updated the documentation, if necessary

@tjementum tjementum added the Bug Something isn't working label Feb 3, 2025
@tjementum tjementum self-assigned this Feb 3, 2025
Copy link

linear bot commented Feb 3, 2025

@tjementum tjementum force-pushed the pp-322-the-pull-platform-changes-cli-command-fails-on-windows branch from 311e1af to f57a1f7 Compare February 8, 2025 17:05
@tjementum tjementum force-pushed the pp-322-the-pull-platform-changes-cli-command-fails-on-windows branch from 01ee3fc to 766d075 Compare February 8, 2025 19:02
@tjementum tjementum closed this Feb 8, 2025
@tjementum tjementum deleted the pp-322-the-pull-platform-changes-cli-command-fails-on-windows branch February 8, 2025 19:06
@tjementum tjementum restored the pp-322-the-pull-platform-changes-cli-command-fails-on-windows branch February 8, 2025 19:07
@tjementum tjementum reopened this Feb 8, 2025
@tjementum tjementum merged commit e48344c into main Feb 8, 2025
4 checks passed
@tjementum tjementum deleted the pp-322-the-pull-platform-changes-cli-command-fails-on-windows branch February 8, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant